fix(txpool): derive accurate queued reason for SubPool::Blob #20095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Dec 3, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
I see, this doesnt look super pretty, but best what we can do and not that horrible
Collaborator
|
pending clippy lint fixes |
mattsse
added
C-debt
Contributor
Author
Did it mister |
mattsse
approved these changes
Dec 3, 2025
Collaborator
|
thank you sir |
yongkangc
pushed a commit
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blob subpool aggregates all non-pending blob transactions, not just those missing the blob fee. The previous implementation always reported InsufficientBlobFee, misclassifying cases such as nonce gaps, insufficient balance, too much gas, parked ancestors, or insufficient base fee. This change derives the queued reason for blob transactions from TxState flags in a consistent order (structural first, then fees), and adds unit tests to cover the major combinations. Sub-pool routing is unchanged; only the reported reason is corrected.